New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: radial-bar chart #1818

Merged

hustcc merged 16 commits into antvis:master from yujs:feat/radial-bar

Oct 30, 2020

Contributor

yujs commented Oct 29, 2020

No description provided.

yujs added 6 commits

October 28, 2020 17:39


          feat: add radial bar adaptor

7da9607


          feat: add some unit test files

2d1a959


          feat: add all unit test to radial bar

b4fc576


          feat: add maxRadian

691c228


          feat: add radial bar docs

3f331d7


          feat: add example demo and api

c871733

pr-triage bot added the PR: unreviewed label

visiky reviewed

View reviewed changes

src/index.ts Outdated Show resolved Hide resolved

visiky reviewed

View reviewed changes

src/plots/radial-bar/utils.ts Outdated Show resolved Hide resolved

src/plots/radial-bar/adaptor.ts Outdated Show resolved Hide resolved

src/plots/radial-bar/utils.ts Outdated Show resolved Hide resolved

src/plots/radial-bar/utils.ts Outdated Show resolved Hide resolved

hustcc reviewed

View reviewed changes

__tests__/unit/plots/radial-bar/axis-spec.ts Outdated Show resolved Hide resolved

hustcc reviewed

View reviewed changes

src/index.ts Outdated Show resolved Hide resolved

hustcc reviewed

View reviewed changes

src/plots/radial-bar/adaptor.ts Outdated Show resolved Hide resolved

hustcc reviewed

View reviewed changes

src/plots/radial-bar/adaptor.ts Outdated Show resolved Hide resolved

hustcc reviewed

View reviewed changes

src/plots/radial-bar/adaptor.ts Outdated Show resolved Hide resolved

hustcc reviewed

View reviewed changes

src/plots/radial-bar/adaptor.ts Outdated Show resolved Hide resolved

hustcc reviewed

View reviewed changes

src/plots/radial-bar/index.ts Outdated Show resolved Hide resolved

hustcc reviewed

View reviewed changes

src/plots/radial-bar/types.ts Outdated Show resolved Hide resolved

hustcc reviewed

View reviewed changes

src/plots/radial-bar/utils.ts Outdated Show resolved Hide resolved

hustcc reviewed

View reviewed changes

src/plots/radial-bar/utils.ts Outdated Show resolved Hide resolved

arcsin1 reviewed

View reviewed changes

src/plots/radial-bar/adaptor.ts Show resolved Hide resolved

Contributor

arcsin1 commented Oct 29, 2020 •

edited

Loading

貌似少了label的处理，要处理下?
en,en文字是否需要单独处理?

Member

hustcc commented Oct 29, 2020

额外提一下，单元测试覆盖率需要到 95% 以上。

hustcc reviewed

View reviewed changes

src/plots/radial-bar/adaptor.ts Outdated Show resolved Hide resolved

hustcc reviewed

View reviewed changes

src/plots/radial-bar/index.ts Show resolved Hide resolved

yujs added 6 commits

October 30, 2020 10:16


          feat: ajust RadialBar export position

958da74


          feat: delete console log

9b85c92


          feat: add antV star data into test and demo

825aeb5


          feat: add radius and innerRadius

97774a6


          feat: add radius and innerRadius docs

591d479


          feat: modify xAxis default option

a91dcd7


          feat: remove tooltip default title

74c4155

arcsin1 reviewed

View reviewed changes

src/index.ts Outdated Show resolved Hide resolved

yujs added 2 commits

October 30, 2020 15:44


          feat: fixed some issues

9e1488e


          feat: modify demo innerRadius value

6b44ff4

Contributor Author

yujs commented Oct 30, 2020

貌似少了label的处理，要处理下?

en,en文字是否需要单独处理?

yujs closed this

yujs reopened this


          Merge branch 'master' into feat/radial-bar

da001a8

hustcc approved these changes

View reviewed changes

pr-triage bot added PR: reviewed-approved and removed PR: unreviewed labels

hustcc merged commit 07ae1d0 into antvis:master

pr-triage bot added PR: merged and removed PR: reviewed-approved labels

Contributor

github-actions bot commented Oct 30, 2020 •

edited

Loading

😭 Deploy PR Preview 07ae1d0 failed. Build logs

_{🤖 By surge-preview}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels